[Visualize] Fixes functional tests to run for vislib and es-charts #101461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
stratoula
added
v7.14.0
v8.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
added
the
release_note:skip
stratoula
added
Feature:Functional Testing
Feature:Visualizations
LeeDr
approved these changes
Jun 7, 2021
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the visualize functional tests. Specifically, due to this change #98063, the functional tests that tested the es-charts implementation never run with the
visualization:visualize:legacyChartsLibraryset to false. As a result, ci-group4 and ci-group7 were testing twice the vislib implementation.I have changed this in order ci-group7 to run the tests for es-charts and ci-group4 to run the tests for vislib.
Checklist